feat: Change org selector add gh integration button behavior #102680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/components/prevent/integratedOrgSelector/integratedOrgSelector.tsx
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/components/prevent/integratedOrgSelector/integratedOrgSelector.tsx
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102680 +/- ##
========================================
Coverage 80.90% 80.90%
========================================
Files 8871 8871
Lines 390913 390901 -12
Branches 24849 24844 -5
========================================
- Hits 316254 316248 -6
+ Misses 74293 74287 -6
Partials 366 366 |
calvin-codecov
commented
Nov 5, 2025
| }: AddIntegrationButtonProps) { | ||
| const label = | ||
| (buttonText ?? reinstall) | ||
| buttonText ?? |
Contributor
Author
There was a problem hiding this comment.
This is fixing a bug introduced when prettier formatting was applied adding parentheses. When buttonText existed, it would give "Enable" instead of buttonText.
static/app/components/prevent/integratedOrgSelector/integratedOrgSelector.tsx
Outdated
Show resolved
Hide resolved
static/app/components/prevent/integratedOrgSelector/integratedOrgSelector.tsx
Outdated
Show resolved
Hide resolved
calvin-codecov
force-pushed
the
cy/selector_gh_link
branch
from
63b4538 to
36dca2b
Compare
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Followup to https://linear.app/getsentry/issue/CCMRG-1689/redirect-the-integrated-org-link Changes link to org integrated selection "Add GitHub organization" button to also open GH OAuth. Opens popout window to this link like Settings>Integration and now the TA Preonboarding page also after above PR <img width="1072" height="140" alt="Screenshot 2025-11-06 at 11 31 31 AM" src="https://github.com/user-attachments/assets/7385128c-b673-430f-bdc8-e9ac2f44d9e9" />
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Followup to https://linear.app/getsentry/issue/CCMRG-1689/redirect-the-integrated-org-link Changes link to org integrated selection "Add GitHub organization" button to also open GH OAuth. Opens popout window to this link like Settings>Integration and now the TA Preonboarding page also after above PR <img width="1072" height="140" alt="Screenshot 2025-11-06 at 11 31 31 AM" src="https://github.com/user-attachments/assets/7385128c-b673-430f-bdc8-e9ac2f44d9e9" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to https://linear.app/getsentry/issue/CCMRG-1689/redirect-the-integrated-org-link
Changes link to org integrated selection "Add GitHub organization" button to also open GH OAuth.
Opens popout window to this link like Settings>Integration and now the TA Preonboarding page also after above PR
