Skip to content

Conversation

@Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Nov 4, 2025

The trace metrics dataset needs a TraceMetricsSearchResolverConfig instead.

@Zylphrex Zylphrex requested a review from a team as a code owner November 4, 2025 18:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ry/api/endpoints/organization_events_timeseries.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #102700      +/-   ##
===========================================
+ Coverage   77.49%    80.94%   +3.44%     
===========================================
  Files        8927      8930       +3     
  Lines      391097    391179      +82     
  Branches    24858     24858              
===========================================
+ Hits       303066    316621   +13555     
+ Misses      87663     74190   -13473     
  Partials      368       368              

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 thanks!

@Zylphrex Zylphrex merged commit e07e1b2 into master Nov 4, 2025
67 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/handle-top-level-metrics-query-params-on-timeseries branch November 4, 2025 20:46
priscilawebdev pushed a commit that referenced this pull request Nov 6, 2025
…ies (#102700)

The trace metrics dataset needs a `TraceMetricsSearchResolverConfig`
instead.
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
…ies (#102700)

The trace metrics dataset needs a `TraceMetricsSearchResolverConfig`
instead.
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
…ies (#102700)

The trace metrics dataset needs a `TraceMetricsSearchResolverConfig`
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants