Skip to content

fix(codecov): Fix line coverage legend edge cases and coloring #102742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2025
Merged

fix(codecov): Fix line coverage legend edge cases and coloring #102742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7aed6d4
fix(codecov): Fix line coverage legend edge cases and coloring
calvin-codecov Nov 4, 2025
63e47aa
fix(codecov): Update component structuring review changes
calvin-codecov Nov 6, 2025
43e145a
fix(codecov): Update frame line number indication colors
calvin-codecov Nov 6, 2025
e9a40c3
fix(codecov): Add back dash styling
calvin-codecov Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions static/app/components/events/interfaces/crashContent/exception/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Fragment, useState} from 'react';
import styled from '@emotion/styled';

import {Button} from 'sentry/components/core/button';
import {Flex} from 'sentry/components/core/layout/flex';
import {Container} from 'sentry/components/core/layout';
import {Tooltip} from 'sentry/components/core/tooltip';
import ErrorBoundary from 'sentry/components/errorBoundary';
import {StacktraceBanners} from 'sentry/components/events/interfaces/crashContent/exception/banners/stacktraceBanners';
Expand Down Expand Up @@ -205,16 +205,15 @@ function InnerContent({
<ToggleExceptionButton
{...{hiddenExceptions, toggleRelatedExceptions, values, exception}}
/>
{exception.mechanism || hasCoverageData ? (
<RowWrapper direction="row" justify="between">
{exception.mechanism && (
<Mechanism
data={exception.mechanism}
meta={meta?.[exceptionIdx]?.mechanism}
/>
)}
{hasCoverageData ? <LineCoverageLegend /> : null}
</RowWrapper>
{exception.mechanism ? (
<Container paddingTop="xl">
<Mechanism data={exception.mechanism} meta={meta?.[exceptionIdx]?.mechanism} />
</Container>
) : null}
{hasCoverageData ? (
<Container paddingTop="md">
<LineCoverageLegend />
</Container>
) : null}
<RelatedExceptions
mechanism={exception.mechanism}
Expand Down Expand Up @@ -411,7 +410,3 @@ const StyledFoldSection = styled(FoldSection)`
margin-right: ${p => p.theme.space.xl};
}
`;

const RowWrapper = styled(Flex)`
margin: ${p => p.theme.space.xl} 0 ${p => p.theme.space.xs} 0;
`;
Comment on lines -415 to -417
Copy link
Member

@JonasBa JonasBa Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the better way to handle the wrapper requirement at the call site

43 changes: 24 additions & 19 deletions static/app/components/events/interfaces/crashContent/exception/lineCoverageLegend.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,38 @@
import styled from '@emotion/styled';

import {Flex} from 'sentry/components/core/layout/flex';
import {Container, Flex} from 'sentry/components/core/layout';
import {Text} from 'sentry/components/core/text/text';
import {coverageText as COVERAGE_TEXT} from 'sentry/components/events/interfaces/frame/contextLineNumber';
import {Coverage} from 'sentry/types/integrations';

export function LineCoverageLegend() {
return (
<Flex gap="2xl" align="center" direction="row" paddingBottom="md">
<CoveredLine>{COVERAGE_TEXT[Coverage.COVERED]}</CoveredLine>
<UncoveredLine>{COVERAGE_TEXT[Coverage.NOT_COVERED]}</UncoveredLine>
<PartiallyCoveredLine>{COVERAGE_TEXT[Coverage.PARTIAL]}</PartiallyCoveredLine>
<Flex gap="2xl" align="center" direction="row" wrap="wrap">
<SolidLegendEntry paddingRight="md" borderRight="success">
<Text size="sm" wrap="nowrap">
{COVERAGE_TEXT[Coverage.COVERED]}
</Text>
</SolidLegendEntry>
<SolidLegendEntry paddingRight="md" borderRight="danger">
<Text size="sm" wrap="nowrap">
{COVERAGE_TEXT[Coverage.NOT_COVERED]}
</Text>
</SolidLegendEntry>
<DashedLegendEntry paddingRight="md" borderRight="warning">
<Text size="sm" wrap="nowrap">
{COVERAGE_TEXT[Coverage.PARTIAL]}
</Text>
</DashedLegendEntry>
</Flex>
);
}

const CoveredLine = styled('div')`
padding-right: ${p => p.theme.space.md};
border-right: 3px solid ${p => p.theme.tokens.content.success};
white-space: nowrap;
const SolidLegendEntry = styled(Container)`
border-right-width: 3px;
border-right-style: solid;
`;

const UncoveredLine = styled('div')`
padding-right: ${p => p.theme.space.md};
border-right: 3px solid ${p => p.theme.tokens.content.danger};
white-space: nowrap;
`;

const PartiallyCoveredLine = styled('div')`
padding-right: ${p => p.theme.space.md};
border-right: 3px dashed ${p => p.theme.tokens.content.warning};
white-space: nowrap;
const DashedLegendEntry = styled(Container)`
border-right-width: 3px;
border-right-style: dashed;
`;
6 changes: 3 additions & 3 deletions static/app/components/events/interfaces/frame/contextLineNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@ const Wrapper = styled('div')`

&.covered .line-number {
background: ${p => p.theme.green100};
border-right: 3px solid ${p => p.theme.tokens.content.success};
border-right: 3px solid ${p => p.theme.tokens.border.success};
}

&.uncovered .line-number {
background: ${p => p.theme.red100};
border-right: 3px solid ${p => p.theme.tokens.content.danger};
border-right: 3px solid ${p => p.theme.tokens.border.danger};
}

&.partial .line-number {
background: ${p => p.theme.yellow100};
border-right: 3px dashed ${p => p.theme.tokens.content.warning};
border-right: 3px dashed ${p => p.theme.tokens.border.warning};
}

&.active {
Expand Down
Loading