Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ releases: 0003_real_delete_dual_written_commit_tables

replays: 0006_add_bulk_delete_job

sentry: 1003_group_history_prev_history_safe_removal
sentry: 1004_add_semver_with_build_code_index

social_auth: 0003_social_auth_json_field

Expand Down
53 changes: 53 additions & 0 deletions src/sentry/migrations/1004_add_semver_with_build_code_index.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# Generated by Django 5.2.1 on 2025-11-05 22:32

from django.db import migrations, models

from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("sentry", "1003_group_history_prev_history_safe_removal"),
]

operations = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will let the folks on the db migration reviewers group chime in but i think we want to first create the new index, then drop the old one after in a separate migration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should switch these if we go ahead with this

migrations.AddIndex(
model_name="release",
index=models.Index(
models.F("organization"),
models.OrderBy(models.F("major"), descending=True),
models.OrderBy(models.F("minor"), descending=True),
models.OrderBy(models.F("patch"), descending=True),
models.OrderBy(models.F("revision"), descending=True),
models.OrderBy(
models.Case(models.When(prerelease="", then=1), default=0), descending=True
),
models.OrderBy(models.F("prerelease"), descending=True),
models.OrderBy(
models.Case(
models.When(build_code__isnull=False, build_number__isnull=True, then=2),
models.When(build_number__isnull=False, then=1),
default=0,
),
descending=True,
),
models.OrderBy(models.F("build_number"), descending=True),
models.OrderBy(models.F("build_code"), descending=True),
name="sentry_release_semver_new_idx",
),
),
]
17 changes: 17 additions & 0 deletions src/sentry/models/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,23 @@ class Meta:
F("prerelease").desc(),
name="sentry_release_semver_idx",
),
models.Index(
"organization",
F("major").desc(),
F("minor").desc(),
F("patch").desc(),
F("revision").desc(),
Case(When(prerelease="", then=1), default=0).desc(),
F("prerelease").desc(),
Case(
When(build_number__isnull=True, build_code__isnull=False, then=2),
When(build_number__isnull=False, then=1),
default=0,
).desc(),
F("build_number").desc(),
F("build_code").desc(),
name="sentry_release_semver_new_idx",
),
models.Index(fields=("organization", "build_code")),
models.Index(fields=("organization", "build_number")),
models.Index(fields=("organization", "date_added")),
Expand Down
Loading