Skip to content

fix(tracemetrics): Properly fall back to high accuracy #102828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix(tracemetrics): Properly fall back to high accuracy #102828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions static/app/views/explore/metrics/hooks/useMetricAggregatesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
} from 'sentry/views/explore/hooks/useProgressiveQuery';
import type {TraceMetric} from 'sentry/views/explore/metrics/metricQuery';
import {useMetricVisualize} from 'sentry/views/explore/metrics/metricsQueryParams';
import {TraceMetricKnownFieldKey} from 'sentry/views/explore/metrics/types';
import {
useQueryParamsAggregateSortBys,
useQueryParamsGroupBys,
Expand All @@ -32,6 +33,8 @@ interface MetricAggregatesTableResult {
result: ReturnType<typeof useSpansQuery<any[]>>;
}

const COUNT_AGGREGATE = `count(${TraceMetricKnownFieldKey.METRIC_NAME})`;

export function useMetricAggregatesTable({
enabled,
limit,
Expand All @@ -41,7 +44,10 @@ export function useMetricAggregatesTable({
const canTriggerHighAccuracy = useCallback(
(result: ReturnType<typeof useMetricAggregatesTableImp>['result']) => {
const canGoToHigherAccuracyTier = result.meta?.dataScanned === 'partial';
const hasData = defined(result.data) && result.data.length > 0;
const hasData =
defined(result.data) &&
(result.data.length > 1 ||
(result.data.length === 1 && Boolean(result.data[0][COUNT_AGGREGATE])));
return !hasData && canGoToHigherAccuracyTier;
},
[]
Expand Down Expand Up @@ -97,7 +103,7 @@ function useMetricAggregatesTableImp({
const discoverQuery: NewQuery = {
id: undefined,
name: 'Explore - Metric Aggregates',
fields,
fields: [...fields, COUNT_AGGREGATE],
orderby: sortBys.map(formatSort),
query,
version: 2,
Expand Down
Loading