fix(aci): add support for time window offsets to open period serializer #102840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
scttcper
approved these changes
Nov 6, 2025
Ahmed-Labs
pushed a commit
that referenced
this pull request
Nov 6, 2025
…er (#102840) Do this so that metric issue charts do not have their open period markers offset by one time window. Edited the helper function that gets the offset time to make it simpler, as we don't currently do anything with threshold_period.
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
…er (#102840) Do this so that metric issue charts do not have their open period markers offset by one time window. Edited the helper function that gets the offset time to make it simpler, as we don't currently do anything with threshold_period.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…er (#102840) Do this so that metric issue charts do not have their open period markers offset by one time window. Edited the helper function that gets the offset time to make it simpler, as we don't currently do anything with threshold_period.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this so that metric issue charts do not have their open period markers offset by one time window. Edited the helper function that gets the offset time to make it simpler, as we don't currently do anything with threshold_period.