Skip to content

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Nov 6, 2025

When clicking a breadcrumb to navigate away from replay view (e.g. clicking on error link), it triggers click handlers for setting the player timestamp. This causes a lot of rrweb warnings/errors as it tries to play after the replayer is destroyed since we are navigating away.

Note there may be more instances of this bug, for now this only addresses Issue breadcrumbs.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 6, 2025
When clicking a breadcrumb to navigate away from replay view (e.g. clicking on error link), it triggers click handlers for setting the player timestamp. This causes a lot of rrweb warnings/errors as it tries to play after the replayer is destroyed since we are navigating away.
@billyvg billyvg force-pushed the billy/fix-moment-deprecation-useFlagSeries branch from 917229b to 7ced13b Compare November 6, 2025 17:22
@billyvg billyvg changed the title fix(ui): moment deprecated date formatting in useFlagSeries() fix(replay): Navigation away from replay details causes rrweb errors Nov 6, 2025
@billyvg
Copy link
Member Author

billyvg commented Nov 6, 2025

@sentry review

@billyvg billyvg marked this pull request as ready for review November 6, 2025 17:25
@billyvg billyvg requested a review from a team as a code owner November 6, 2025 17:25
@billyvg billyvg merged commit eb40d63 into master Nov 6, 2025
49 checks passed
@billyvg billyvg deleted the billy/fix-moment-deprecation-useFlagSeries branch November 6, 2025 17:46
Ahmed-Labs pushed a commit that referenced this pull request Nov 6, 2025
…102877)

When clicking a breadcrumb to navigate away from replay view (e.g.
clicking on error link), it triggers click handlers for setting the
player timestamp. This causes a lot of rrweb warnings/errors as it tries
to play after the replayer is destroyed since we are navigating away.

Note there may be more instances of this bug, for now this only
addresses Issue breadcrumbs.
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
…102877)

When clicking a breadcrumb to navigate away from replay view (e.g.
clicking on error link), it triggers click handlers for setting the
player timestamp. This causes a lot of rrweb warnings/errors as it tries
to play after the replayer is destroyed since we are navigating away.

Note there may be more instances of this bug, for now this only
addresses Issue breadcrumbs.
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
…102877)

When clicking a breadcrumb to navigate away from replay view (e.g.
clicking on error link), it triggers click handlers for setting the
player timestamp. This causes a lot of rrweb warnings/errors as it tries
to play after the replayer is destroyed since we are navigating away.

Note there may be more instances of this bug, for now this only
addresses Issue breadcrumbs.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants