Skip to content

Conversation

@scttcper
Copy link
Member

@scttcper scttcper commented Nov 6, 2025

The package is now esm only and drops a few weird sub-dependencies it had like is-arrayish and simple-swizzle

The package is esm and drops a few weird dependencies it had like is-arrayish and simple-swizzle
@scttcper scttcper requested a review from a team November 6, 2025 18:28
@scttcper scttcper requested review from a team as code owners November 6, 2025 18:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 6, 2025
Comment on lines 83 to 88
"@tanstack/react-query-devtools": "5.85.0",
"@tanstack/react-query-persist-client": "5.85.0",
"@tanstack/react-virtual": "^3.13.6",
"@types/color": "^3.0.3",
"@types/diff": "5.2.1",
"@types/gtag.js": "^0.0.12",
"@types/history": "^3.2.5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: color package v5 removes opaquer(), but code still calls it, leading to a TypeError.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The color package was upgraded to v5.0.2, which removed the opaquer() method. Existing code in static/app/utils/theme/theme.tsx and static/app/utils/theme/theme.chonk.tsx continues to call color(...).opaquer(1.0).string(). This will result in a TypeError: color(...).opaquer is not a function during application initialization, preventing the UI from loading.

💡 Suggested Fix

Replace all calls to color(...).opaquer(value) with color(...).alpha(value) to align with the color v5 API.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L83-L88

Potential issue: The `color` package was upgraded to v5.0.2, which removed the
`opaquer()` method. Existing code in `static/app/utils/theme/theme.tsx` and
`static/app/utils/theme/theme.chonk.tsx` continues to call
`color(...).opaquer(1.0).string()`. This will result in a `TypeError: color(...).opaquer
is not a function` during application initialization, preventing the UI from loading.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does WHAT

@scttcper scttcper merged commit 66bf552 into master Nov 6, 2025
48 checks passed
@scttcper scttcper deleted the scttcper/bump-color branch November 6, 2025 18:44
Ahmed-Labs pushed a commit that referenced this pull request Nov 6, 2025
The package is now esm only and drops a few weird sub-dependencies it
had like `is-arrayish` and `simple-swizzle`
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
The package is now esm only and drops a few weird sub-dependencies it
had like `is-arrayish` and `simple-swizzle`
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
The package is now esm only and drops a few weird sub-dependencies it
had like `is-arrayish` and `simple-swizzle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants