chore(aci): make DetectorGroup unique on Group #102928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/sentry/workflow_engine/migrations/0095_unique_detectorgroup_group.py
Show resolved
Hide resolved
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Alter field group on detectorgroup
--
SET CONSTRAINTS "workflow_engine_dete_group_id_9ff57c8f_fk_sentry_gr" IMMEDIATE; ALTER TABLE "workflow_engine_detectorgroup" DROP CONSTRAINT "workflow_engine_dete_group_id_9ff57c8f_fk_sentry_gr";
DROP INDEX CONCURRENTLY IF EXISTS "workflow_engine_detectorgroup_group_id_9ff57c8f";
CREATE UNIQUE INDEX CONCURRENTLY "workflow_engine_detectorgroup_group_id_9ff57c8f_uniq" ON "workflow_engine_detectorgroup" ("group_id");
ALTER TABLE "workflow_engine_detectorgroup" ADD CONSTRAINT "workflow_engine_detectorgroup_group_id_9ff57c8f_uniq" UNIQUE USING INDEX "workflow_engine_detectorgroup_group_id_9ff57c8f_uniq";
ALTER TABLE "workflow_engine_detectorgroup" ADD CONSTRAINT "workflow_engine_dete_group_id_9ff57c8f_fk_sentry_gr" FOREIGN KEY ("group_id") REFERENCES "sentry_groupedmessage" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_detectorgroup" VALIDATE CONSTRAINT "workflow_engine_dete_group_id_9ff57c8f_fk_sentry_gr";
--
-- Alter unique_together for detectorgroup (0 constraint(s))
--
ALTER TABLE "workflow_engine_detectorgroup" DROP CONSTRAINT "workflow_engine_detector_detector_id_group_id_02ffc513_uniq"; |
wedamija
reviewed
Nov 6, 2025
Comment on lines
31
to
41
| migrations.AlterUniqueTogether( | ||
| name="detectorgroup", | ||
| unique_together=set(), | ||
| ), | ||
| migrations.AlterField( | ||
| model_name="detectorgroup", | ||
| name="group", | ||
| field=sentry.db.models.fields.foreignkey.FlexibleForeignKey( | ||
| on_delete=django.db.models.deletion.CASCADE, to="sentry.group", unique=True | ||
| ), | ||
| ), |
Member
There was a problem hiding this comment.
We should switch this order around, otherwise we won't be covered by the unique index for a while and might introduce bad rows
| class Meta: | ||
| db_table = "workflow_engine_detectorgroup" | ||
| app_label = "workflow_engine" | ||
| unique_together = (("detector", "group"),) |
Member
There was a problem hiding this comment.
I think we're safe enough without this index. If we search on detector_id, group_id it can just use the unique on group. The only case I can think of where this old index might have been helpful if we did where detector_id = x order by group_id, which doesn't seem like it'd happen too often
cathteng
force-pushed
the
cathy/aci/unique-detectorgroup-group
branch
from
82c0867 to
b769a0c
Compare
src/sentry/workflow_engine/migrations/0095_unique_detectorgroup_group.py
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
src/sentry/workflow_engine/migrations/0095_unique_detectorgroup_group.py
Show resolved
Hide resolved
saponifi3d
approved these changes
Nov 10, 2025
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
lgtm, might be nice to have a second pass from @wedamija tho too.
wedamija
approved these changes
Nov 10, 2025
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
lgtm, this might end up being painful to create!
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A group should only be associated with 1 detector. This is a huge table so making it post-deploy, but we still might fail to acquire the lock...