ref(seer): attach project_slug to replay rpc response #102978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return resp.data["data"] | ||
| # Add project_slug field. | ||
| result = resp.data["data"] | ||
| project = Project.objects.get(id=result["project_id"]) |
Contributor
There was a problem hiding this comment.
Bug: Broken Contract: Unhandled Project Not Found
The Project.objects.get(id=result["project_id"]) call lacks exception handling for Project.DoesNotExist. If the replay metadata contains a project_id for a deleted or inaccessible project, the function will crash with an unhandled exception instead of returning None as documented. This breaks the function's contract and differs from the error handling pattern used consistently elsewhere in the same file.
roaga
approved these changes
Nov 7, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102978 +/- ##
===========================================
+ Coverage 79.63% 80.63% +1.00%
===========================================
Files 9093 9095 +2
Lines 392632 392745 +113
Branches 24972 24972
===========================================
+ Hits 312666 316687 +4021
+ Misses 79568 75660 -3908
Partials 398 398 |
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for https://github.com/getsentry/seer/pull/3943