Skip to content

Conversation

@trevor-e
Copy link
Member

@trevor-e trevor-e commented Nov 7, 2025

This is a common issue for orgs when they first integrate and we want extra visibility around when it happens. I see other parts of our integrations codebase treats this as a IntegrationConfigurationError, so doing the same here.

I also noticed that these were being retried up to our limit which doesn't make sense since it is not a recoverable error. I added IntegrationConfigurationError to our error ignore list.

Resolves EME-611

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
29537 1 29536 240
View the top 1 failed test(s) by shortest run time
tests.sentry.preprod.vcs.status_checks.size.test_status_checks_tasks.CreatePreprodStatusCheckTaskTest::test_create_preprod_status_check_task_github_non_permission_403
Stack Traces | 2.67s run time
#x1B[1m#x1B[.../shared_integrations/client/base.py#x1B[0m:258: in _request
    resp.raise_for_status()
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/requests/models.py#x1B[0m:1026: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
#x1B[1m#x1B[31mE   requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.github..../owner/repo/check-runs#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../status_checks/size/tasks.py#x1B[0m:352: in create_status_check
    response = self.client.create_check_run(repo=repo, data=check_data)
#x1B[1m#x1B[.../integrations/github/client.py#x1B[0m:724: in create_check_run
    return self.post(endpoint, data=data)
#x1B[1m#x1B[.../shared_integrations/client/base.py#x1B[0m:356: in post
    return self.request("POST", *args, **kwargs)
#x1B[1m#x1B[.../shared_integrations/client/base.py#x1B[0m:311: in request
    return self._request(*args, **kwargs)
#x1B[1m#x1B[.../shared_integrations/client/base.py#x1B[0m:280: in _request
    raise ApiError.from_response(error_resp, url=full_url) from e
#x1B[1m#x1B[31mE   sentry.shared_integrations.exceptions.ApiForbiddenError: {"message": "Repository is temporarily unavailable"}#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../status_checks/size/test_status_checks_tasks.py#x1B[0m:550: in test_create_preprod_status_check_task_github_non_permission_403
    create_preprod_status_check_task(preprod_artifact.id)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:159: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[.../sentry/taskworker/task.py#x1B[0m:89: in __call__
    return self._func(*args, **kwargs)
#x1B[1m#x1B[.../status_checks/size/tasks.py#x1B[0m:117: in create_preprod_status_check_task
    check_id = provider.create_status_check(
#x1B[1m#x1B[.../status_checks/size/tasks.py#x1B[0m:392: in create_status_check
    raise IntegrationConfigurationError(
#x1B[1m#x1B[31mE   sentry.shared_integrations.exceptions.IntegrationConfigurationError: GitHub API returned 403 client error when creating check run#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@linear
Copy link

linear bot commented Nov 7, 2025

@trevor-e trevor-e marked this pull request as ready for review November 10, 2025 17:50
@trevor-e trevor-e requested a review from a team as a code owner November 10, 2025 17:50
@trevor-e trevor-e merged commit 3d7a9cd into master Nov 10, 2025
65 checks passed
@trevor-e trevor-e deleted the telkins/status-check-permissions branch November 10, 2025 18:12
@sentry
Copy link

sentry bot commented Nov 11, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
This is a common issue for orgs when they first integrate and we want
extra visibility around when it happens. I see other parts of our
integrations codebase treats this as a `IntegrationConfigurationError`,
so doing the same here.

I also noticed that these were being retried up to our limit which
doesn't make sense since it is not a recoverable error. I added
`IntegrationConfigurationError` to our error ignore list.

Resolves EME-611
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
This is a common issue for orgs when they first integrate and we want
extra visibility around when it happens. I see other parts of our
integrations codebase treats this as a `IntegrationConfigurationError`,
so doing the same here.

I also noticed that these were being retried up to our limit which
doesn't make sense since it is not a recoverable error. I added
`IntegrationConfigurationError` to our error ignore list.

Resolves EME-611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants