Skip to content

Conversation

@GabeVillalobos
Copy link
Member

This PR does a few different things:

  1. Updates forwarder code to use common enums for Github header checks.
  2. Passes the request.META property for the headers dictionary as opposed to request.headers
    • Django's META property contains all available headers for the request, while headers property contains only HTTP prefixed ones.
  3. Cleans up some of our spammier logging

@GabeVillalobos GabeVillalobos requested review from a team as code owners November 10, 2025 16:33
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 10, 2025
@GabeVillalobos GabeVillalobos requested a review from a team November 10, 2025 16:34
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/overwatch_webhooks/webhook_forwarder.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103067      +/-   ##
===========================================
+ Coverage   80.65%    80.66%   +0.01%     
===========================================
  Files        9190      9190              
  Lines      392895    393379     +484     
  Branches    24975     24975              
===========================================
+ Hits       316903    317333     +430     
- Misses      75575     75629      +54     
  Partials      417       417              

@GabeVillalobos GabeVillalobos merged commit 6414be4 into master Nov 10, 2025
66 checks passed
@GabeVillalobos GabeVillalobos deleted the gv/minor-refactors-for-webhook-handling-code branch November 10, 2025 17:14
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants