Skip to content

fix(logs): Move trace metrics context within trace details #103125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

fix(logs): Move trace metrics context within trace details #103125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions static/app/views/performance/newTraceDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,12 @@ export default function TraceView() {

return (
<TraceViewLogsDataProvider traceSlug={traceSlug}>
<TraceViewMetricsDataProvider traceSlug={traceSlug}>
<TraceStateProvider
initialPreferences={preferences}
preferencesStorageKey={TRACE_VIEW_PREFERENCES_KEY}
>
<TraceViewImpl traceSlug={traceSlug} />
</TraceStateProvider>
</TraceViewMetricsDataProvider>
<TraceStateProvider
initialPreferences={preferences}
preferencesStorageKey={TRACE_VIEW_PREFERENCES_KEY}
>
<TraceViewImpl traceSlug={traceSlug} />
</TraceStateProvider>
</TraceViewLogsDataProvider>
);
}
Expand Down Expand Up @@ -193,7 +191,9 @@ function TraceViewImpl({traceSlug}: {traceSlug: string}) {
<TraceViewLogsSection scrollContainer={traceInnerLayoutRef} />
) : null}
{currentTab === TraceLayoutTabKeys.METRICS ? (
<TraceViewMetricsSection />
<TraceViewMetricsDataProvider traceSlug={traceSlug}>
<TraceViewMetricsSection />
</TraceViewMetricsDataProvider>
) : null}
{currentTab === TraceLayoutTabKeys.SUMMARY ? (
<TraceSummarySection traceSlug={traceSlug} />
Expand Down
Loading