Skip to content

Conversation

@cathteng
Copy link
Member

@cathteng cathteng commented Nov 11, 2025

List of changes:

  1. Remove usages of issue alert dual write flag
  2. Add option in create_project fixture to create the default detectors and set it to False
  3. Modify the relocation logic for a project to not create the default detectors when creating the project in SaaS because we'll be migrating the default detectors over
  4. Add logic to enforce a single error detector & issue stream detector per project. Allow modifying fields on the detector because different names than the default are expected in some tests
  5. Update logic to use create_detector(project=project) instead of create_detector(project_id=project_id), which causes issues in the modifying fields step above because we'd pass project and project_id to detector.update(**kwargs)
    def create_detector(
    self,
    *args,
    project=None,
    type=ErrorGroupType.slug,
    **kwargs,
    ) -> Detector:
    if project is None:
    project = self.create_project(organization=self.organization)

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103134      +/-   ##
===========================================
+ Coverage   72.87%    80.65%   +7.77%     
===========================================
  Files        9206      9210       +4     
  Lines      393166    393444     +278     
  Branches    25015     25015              
===========================================
+ Hits       286534    317341   +30807     
+ Misses     106207     75678   -30529     
  Partials      425       425              


from sentry.receivers.project_detectors import create_project_detectors

# Temporarily disconnect the signal that auto-creates default detectors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh yeah.

@cathteng cathteng enabled auto-merge (squash) November 12, 2025 17:58
@cathteng cathteng merged commit 8eaaf26 into master Nov 12, 2025
65 checks passed
@cathteng cathteng deleted the cathy/aci/default-issue-alert-dual-write-true branch November 12, 2025 18:19
@sentry
Copy link

sentry bot commented Nov 13, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants