-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(aci): default issue alert dual write to True #103134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(aci): default issue alert dual write to True #103134
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103134 +/- ##
===========================================
+ Coverage 72.87% 80.65% +7.77%
===========================================
Files 9206 9210 +4
Lines 393166 393444 +278
Branches 25015 25015
===========================================
+ Hits 286534 317341 +30807
+ Misses 106207 75678 -30529
Partials 425 425 |
src/sentry/models/project.py
Outdated
|
|
||
| from sentry.receivers.project_detectors import create_project_detectors | ||
|
|
||
| # Temporarily disconnect the signal that auto-creates default detectors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh yeah.
7707c59 to
e4227ec
Compare
tests/sentry/workflow_engine/endpoints/test_organization_detector_index.py
Outdated
Show resolved
Hide resolved
tests/sentry/workflow_engine/endpoints/test_organization_detector_index.py
Show resolved
Hide resolved
tests/sentry/workflow_engine/endpoints/test_organization_detector_index.py
Show resolved
Hide resolved
tests/sentry/workflow_engine/endpoints/test_organization_detector_count.py
Outdated
Show resolved
Hide resolved
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
List of changes:
create_projectfixture to create the default detectors and set it to Falsecreate_detector(project=project)instead ofcreate_detector(project_id=project_id), which causes issues in the modifying fields step above because we'd passprojectandproject_idtodetector.update(**kwargs)sentry/src/sentry/testutils/fixtures.py
Lines 697 to 705 in 74779f8