chore(snuba): test no mutating filter_keys #103181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
roggenkemper
approved these changes
Nov 11, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| conditions=conditions, | ||
| ) | ||
| assert filter_keys == {"group_id": {g4.id}} | ||
| assert conditions == [["group_id", "IN", [g1.id, g4.id]]] |
Contributor
There was a problem hiding this comment.
Bug: Test Fails to Verify Preprocessing Logic
The test doesn't enable the snuba.preprocess-group-redirects option before creating SnubaQueryParams, so _preprocess_group_id_redirects won't execute. This means the test doesn't actually verify that inputs aren't mutated during group redirect preprocessing, which is its intended purpose based on the comment and PR description.
Contributor
Author
There was a problem hiding this comment.
Line 329
options.set("snuba.preprocess-group-redirects", True)
check yourself.
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.