ref(grouping): Add grouping config name constants #103183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103183 +/- ##
===========================================
- Coverage 80.67% 80.66% -0.01%
===========================================
Files 9241 9241
Lines 393627 393629 +2
Branches 25053 25053
===========================================
- Hits 317542 317535 -7
- Misses 75623 75632 +9
Partials 462 462 |
lobsterkatie
force-pushed
the
kmclb-add-grouping-config-name-constants
branch
from
7596034 to
3446ec0
Compare
cvxluo
approved these changes
Nov 11, 2025
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
This adds a constant for the name of the current default grouping config to `server.py` and moves the corresponding constant for the new grouping config to live alongside it, then uses those constants when defining the configs. This lets us separate out the idea of "the `newstyle:2023-01-11` config" from the idea of "the default config," so that we can still refer easily to the former even once the latter has changed.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
This adds a constant for the name of the current default grouping config to `server.py` and moves the corresponding constant for the new grouping config to live alongside it, then uses those constants when defining the configs. This lets us separate out the idea of "the `newstyle:2023-01-11` config" from the idea of "the default config," so that we can still refer easily to the former even once the latter has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a constant for the name of the current default grouping config to
server.pyand moves the corresponding constant for the new grouping config to live alongside it, then uses those constants when defining the configs. This lets us separate out the idea of "thenewstyle:2023-01-11config" from the idea of "the default config," so that we can still refer easily to the former even once the latter has changed.