fix(aci): Encode owner as string when triggering find_channel_id_for_rule #103204
+98
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103204 +/- ##
===========================================
- Coverage 80.67% 80.67% -0.01%
===========================================
Files 9241 9241
Lines 393627 393654 +27
Branches 25053 25053
===========================================
+ Hits 317543 317561 +18
- Misses 75622 75631 +9
Partials 462 462 |
cathteng
approved these changes
Nov 12, 2025
| kwargs.update({"uuid": client.uuid, "rule_id": rule.id}) | ||
| find_channel_id_for_rule.apply_async(kwargs=kwargs) | ||
| # Serialize Actor object to string identifier for task queueing | ||
| task_kwargs = kwargs.copy() |
Member
There was a problem hiding this comment.
Do we need to copy the kwargs if this is the last time they could possibly be modified in this function? We'd overwrite the owner from earlier with json serializable version
Member
Author
There was a problem hiding this comment.
We don't need to, but it's effectively free and keeps this mutation just for the task, new uses of this dict can be added later without needing to know the task requirements.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…rule (#103204) It's unclear that this ever worked properly, but presumably this is a narrow enough case that it hasn't been terribly noticeable. Fixes SENTRY-54ZZ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear that this ever worked properly, but presumably this is a narrow enough case that it hasn't been terribly noticeable.
Fixes SENTRY-54ZZ.