Skip to content

chore: Remove deprecatedRouteProps for /pull/ #103223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
+6 −9
Merged

chore: Remove deprecatedRouteProps for /pull/ #103223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static/app/router/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2568,7 +2568,6 @@ function buildRoutes(): RouteObject[] {
component: make(() => import('sentry/views/pullRequest/index')),
withOrgPath: true,
children: pullRequestChildren,
deprecatedRouteProps: true,
};

const feedbackV2Children: SentryRouteObject[] = [
Expand Down
14 changes: 6 additions & 8 deletions static/app/views/pullRequest/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import {Outlet} from 'react-router-dom';

import Feature from 'sentry/components/acl/feature';
import {Alert} from 'sentry/components/core/alert';
import * as Layout from 'sentry/components/layouts/thirds';
Expand All @@ -6,11 +8,7 @@ import {t} from 'sentry/locale';
import {UrlParamBatchProvider} from 'sentry/utils/url/urlParamBatchContext';
import useOrganization from 'sentry/utils/useOrganization';

type Props = {
children: NonNullable<React.ReactNode>;
};

function PullRequestContainer({children}: Props) {
export default function PullRequestContainer() {
Copy link

@sentry sentry bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from a named export to a default export is appropriate. However, verify that no other files are importing PullRequestContainer as a named import (e.g., import { PullRequestContainer }). Search the codebase for any named imports to ensure compatibility. Only the route configuration should reference this component via default export.
Severity: MEDIUM

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/pullRequest/index.tsx#L11

Potential issue: The change from a named export to a default export is appropriate.
However, verify that no other files are importing `PullRequestContainer` as a named
import (e.g., `import { PullRequestContainer }`). Search the codebase for any named
imports to ensure compatibility. Only the route configuration should reference this
component via default export.

Did we get this right? 👍 / 👎 to inform future reviews.

const organization = useOrganization();

return (
Expand All @@ -28,10 +26,10 @@ function PullRequestContainer({children}: Props) {
)}
>
<NoProjectMessage organization={organization}>
<UrlParamBatchProvider>{children}</UrlParamBatchProvider>
<UrlParamBatchProvider>
<Outlet />
</UrlParamBatchProvider>
</NoProjectMessage>
</Feature>
);
}
Comment on lines 26 to 35
Copy link

@sentry sentry bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration from a children prop to React Router v6's <Outlet /> component is correctly implemented. The component now properly renders nested routes. However, ensure that the UrlParamBatchProvider is the appropriate context wrapper for the <Outlet />. If this provider was previously wrapping only specific child components, verify that wrapping the entire <Outlet /> is the intended behavior and won't cause unintended side effects on all nested routes.
Severity: MEDIUM

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/pullRequest/index.tsx#L1-L35

Potential issue: The migration from a children prop to React Router v6's `<Outlet />`
component is correctly implemented. The component now properly renders nested routes.
However, ensure that the `UrlParamBatchProvider` is the appropriate context wrapper for
the `<Outlet />`. If this provider was previously wrapping only specific child
components, verify that wrapping the entire `<Outlet />` is the intended behavior and
won't cause unintended side effects on all nested routes.

Did we get this right? 👍 / 👎 to inform future reviews.


export default PullRequestContainer;
Loading