feat(tracemetrics): Update nav event #103244
Merged
+23
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates with better fields.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| metricsSupportedPlatformNameRef.current = metricsSupportedPlatform?.slug; | ||
| } | ||
|
|
||
| const hasMetricsSupportedPlatform = !!metricsSupportedPlatformNameRef.current; |
Contributor
There was a problem hiding this comment.
Bug: Metrics UI Out of Sync with Project Data
The metricsSupportedPlatformNameRef is set conditionally during render and never updates when projects changes. If projects load asynchronously or change later, hasMetricsSupportedPlatform will remain stale, preventing the Metrics nav item from appearing even when supported platforms exist, and causing analytics to report incorrect data.
AbhiPrasad
approved these changes
Nov 12, 2025
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Updates with better fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates with better fields.