-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(explorer/replay): support short id details query for replay metadata rpc #103269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
roaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai stuff looks fine to me, defer to replay team on queries
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
JoshFerge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try and figure out a way to pass in the full ID -- ideally we could avoid this complexity
|
|
||
| select = select_from_fields(fields, user_id=request_user_id) | ||
|
|
||
| return Query( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we potentially do a pre-query to only look at the replay id? but no worries if you want to leave it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah makes sense we can! in fact I could refactor this so the util is just a short ID lookup, don't want people calling the inefficient aggregate query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a big TODO on this one and the trace one to optimize and/or figure out how to pass in full ids! :D
Supports replay ID prefix -> full ID lookup, for Seer explorer tools. This filter doesn't make use of the replay_id index and isn't very efficient. However we
The agent is instructed to always provide the full ID and/or project ID when known, which improves performance.
--(Outdated, used to do the prefix filter on the aggregate query)--
Tested a 14d range in snuba admin for sentry prod (project id 11276). Execution time < 60ms, quota_used":167443648,"quota_unit":"bytes"