Skip to content

Conversation

@mujacica
Copy link
Contributor

This PR adds the boilerplate and infrastructure for Perforce/Helix Core integration:

  • Type definitions: Added PERFORCE to ExternalProviders and IntegrationProviderSlug
  • Model updates: Added Perforce to external actor provider choices
  • Integration registration: Registered PerforceIntegrationProvider
  • Feature flag: Added organizations:integrations-perforce
  • Dependencies: Added p4python package
  • Stub implementations: Created empty Perforce integration, client, and repository classes with all method signatures

All methods are stubbed out with proper type hints and docstrings. Implementation will be added in a follow-up PR.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 70.58824% with 45 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/perforce/integration.py 72.46% 19 Missing ⚠️
src/sentry/integrations/perforce/client.py 59.09% 18 Missing ⚠️
src/sentry/integrations/perforce/repository.py 80.00% 5 Missing ⚠️
...ations/api/endpoints/organization_code_mappings.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103287      +/-   ##
===========================================
+ Coverage   79.60%    80.69%   +1.08%     
===========================================
  Files        9226      9230       +4     
  Lines      394094    394247     +153     
  Branches    25121     25121              
===========================================
+ Hits       313725    318133    +4408     
+ Misses      79921     75666    -4255     
  Partials      448       448              

mujacica and others added 4 commits November 13, 2025 13:34
This PR adds the boilerplate and infrastructure for Perforce/Helix Core integration:

- Type definitions: Added PERFORCE to ExternalProviders and IntegrationProviderSlug
- Model updates: Added Perforce to external actor provider choices
- Integration registration: Registered PerforceIntegrationProvider
- Feature flag: Added organizations:integrations-perforce
- Dependencies: Added p4python package
- Stub implementations: Created empty Perforce integration, client, and repository classes with all method signatures

All methods are stubbed out with proper type hints and docstrings. Implementation will be added in a follow-up PR.
@mujacica mujacica force-pushed the feat/perforce-integration branch from a978a06 to 1197dcd Compare November 13, 2025 12:35
@mujacica mujacica marked this pull request as ready for review November 13, 2025 12:58
@mujacica mujacica requested review from a team as code owners November 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants