fix(tracemetrics): Update split panel to use different ratio for nav open state #103297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
nsdeschenes
approved these changes
Nov 13, 2025
nsdeschenes
approved these changes
Nov 13, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Bug: Panel Sizing Inconsistency Hides Icons
The max constraint for the left panel uses width - MIN_RIGHT_WIDTH (370px for right panel) but the defaultSplit calculation ensures 506px for the right panel to show telemetry icons. This inconsistency allows users to drag the divider and shrink the right panel below the size needed to display telemetry icons, defeating the purpose of the changes. The max should use the same calculation as defaultSplit.
static/app/views/explore/metrics/metricPanel/sideBySideOrientation.tsx#L101-L102
sentry/static/app/views/explore/metrics/metricPanel/sideBySideOrientation.tsx
Lines 101 to 102 in 3cc9329
narsaynorath
deleted the
nar/fix/tracemetrics-update-split-panel-ratio-by-nav-collapsed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always tries to show all of the telemetry icons on the right panel in the default split, not the minimum right side width.