fix(typing): add some types to tagstore #103405
Merged
+131
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working in this neck of the woods and keep getting confused about what things are returning. Adding some (but not all) types to help myself get a stronger hold of things. Not fully typing due to prioritization + some not-expecting-None problems. TEST PLAN: `mypy` passes
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Nov 14, 2025
thetruecpaul
commented
Nov 14, 2025
| project_id, | ||
| None, | ||
| environment_id and [environment_id], | ||
| environment_id if environment_id is None else [environment_id], |
Contributor
Author
There was a problem hiding this comment.
this is technically a behavorial change in that previously it would pass in a list of ints, None, or the literal int zero. Now it only passes in a list of ints or None. Every indication that I see points towards this being closer to the intention, but worth calling out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working in this neck of the woods and keep getting confused about what things are returning. Adding some (but not all) types to help myself get a stronger hold of things.
Not fully typing due to prioritization + some not-expecting-None problems.
TEST PLAN:
mypypasses