-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(explorer): support generic table and timeseries rpcs and migrate existing tools to them #103413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can revert the changes to the trace_query rpcs so we can still call them from seer, in case this doesn't work. Refactoring seer tools now |
| project_ids: list[int] | None = None, | ||
| project_slugs: list[str] | None = None, | ||
| sampling_mode: SAMPLING_MODES = "NORMAL", | ||
| partial: Literal["0", "1"] | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only used by issues event timeseries atm
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103413 +/- ##
============================================
+ Coverage 69.63% 80.67% +11.04%
============================================
Files 9236 9242 +6
Lines 394525 394844 +319
Branches 25147 25147
============================================
+ Hits 274726 318557 +43831
+ Misses 119352 75840 -43512
Partials 447 447 |
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
Allows us to make generic (dataset agnostic) EAP table and timeseries queries through Seer RPC. These 2 RPCs are mainly wrappers around the /events/ and /events-stats/ sentry endpoints. Bonus of supporting project_slug filters, which is what the agent works with
For testing purposes, the trace_query RPCs are still supported but call the generic ones under the hood. We plan to eventually deprecate these and migrate the agent tools to the generics