Skip to content

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Nov 14, 2025

Allows us to make generic (dataset agnostic) EAP table and timeseries queries through Seer RPC. These 2 RPCs are mainly wrappers around the /events/ and /events-stats/ sentry endpoints. Bonus of supporting project_slug filters, which is what the agent works with

For testing purposes, the trace_query RPCs are still supported but call the generic ones under the hood. We plan to eventually deprecate these and migrate the agent tools to the generics

@aliu39 aliu39 requested a review from a team as a code owner November 14, 2025 23:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 14, 2025
@aliu39 aliu39 requested a review from roaga November 14, 2025 23:03
@aliu39
Copy link
Member Author

aliu39 commented Nov 14, 2025

Can revert the changes to the trace_query rpcs so we can still call them from seer, in case this doesn't work. Refactoring seer tools now

project_ids: list[int] | None = None,
project_slugs: list[str] | None = None,
sampling_mode: SAMPLING_MODES = "NORMAL",
partial: Literal["0", "1"] | None = None,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only used by issues event timeseries atm

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/seer/explorer/tools.py 55.81% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           master   #103413       +/-   ##
============================================
+ Coverage   69.63%    80.67%   +11.04%     
============================================
  Files        9236      9242        +6     
  Lines      394525    394844      +319     
  Branches    25147     25147               
============================================
+ Hits       274726    318557    +43831     
+ Misses     119352     75840    -43512     
  Partials      447       447               

@aliu39 aliu39 merged commit c479fcd into master Nov 15, 2025
66 checks passed
@aliu39 aliu39 deleted the aliu/trace-query-ref branch November 15, 2025 01:01
@sentry
Copy link

sentry bot commented Nov 17, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants