ref: do not allow uncontrolled compactSelect #103637
Merged
+12
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultValueis used for uncontrolled components - those that do not have anonChangehandler. You usually either passdefaultValue(fully uncontrolled), or you passvalue+onChange(fully controlled)uncontrolled only makes sense in forms where you take the “html” value from the form submit handler, which is not something we do right now. All usages except one in production are controlled usages.
The one usage in
gsApp/views/subscriptionPage/usageLog.tsxpasses adefaultValuedecoded from the url and has anonChangehandler that navigates. This will work just the same when passingvalue. Actually usingnuqswould make this explicit.Note: This is a preparation for a larger refactoring / perf improvement of
compactSelectto avoid rendering all options eagerly.