ref(scraps): make value and onChange required on compactSelect #103654
+89
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we're switching towards fully controlled usages now that we don't have `defaultValue` anymore, it makes sense to require this on type-level. Most violations were in stories and tests, and in those cases where the value is actually irrelevant e.g. because we do a navigation, we can still explicitly pass value={undefined}
github-actions
bot
added
the
Scope: Frontend
TkDodo
commented
Nov 19, 2025
Comment on lines
-137
to
-140
| <VisibleFocusButton | ||
| <Button | ||
| size="xs" | ||
| borderless | ||
| style={{background: filters.length > 0 ? theme.purple100 : 'transparent'}} |
Collaborator
Author
There was a problem hiding this comment.
note: this didn’t work with UI2 at all so I’ve just removed it an use a regular button now. looks fine to me:
| if (isError) { | ||
| return ( | ||
| <Tooltip title={t('Error loading span categories')}> | ||
| <CompactSelect disabled options={[]} value={undefined} onChange={onChange} /> |
Collaborator
Author
There was a problem hiding this comment.
note: this should probably just be a Button but 🤷♂️
JonasBa
reviewed
Nov 19, 2025
| ); | ||
| } | ||
|
|
||
| const VisibleFocusButton = styled(Button)` |
JonasBa
reviewed
Nov 19, 2025
JonasBa
approved these changes
Nov 19, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <CompactSelect | ||
| grid | ||
| value={undefined} | ||
| onChange={jest.fn} |
Contributor
There was a problem hiding this comment.
Bug: CompactSelect test mocks created incorrectly without function call
All onChange mock assignments use jest.fn (without parentheses) instead of jest.fn() (with parentheses). This passes the jest factory function reference rather than a mock function instance, preventing call tracking. The correct pattern onChange={jest.fn()} is used in composite.spec.tsx and throughout the codebase.
TkDodo
deleted the
tkdodo/ref/compact-select-required-value-and-onChange
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we're switching towards fully controlled usages now that we don't have
defaultValueanymore, it makes sense to require this on type-level. Most violations were in stories and tests, and in those cases where the value is actually irrelevant e.g. because we do a navigation, we can still explicitly pass value={undefined}