feat(Replay): Strip Dash Before EAP Replay Query #103793
Conversation
cliffordxing
changed the title
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| select=select, | ||
| where=[ | ||
| Condition(Column("replay_id"), Op.IN, replay_ids), | ||
| Condition(Column("replay_id"), Op.IN, replay_ids_no_dashes), |
There was a problem hiding this comment.
Bug: Missing WHERE conditions in EAP query
The EAP query is missing critical WHERE conditions for project_id and timestamp that filter results to the specified projects and time range. The function receives project_ids, start, and end parameters but doesn't use them in the query, potentially returning replays from any project and any time period instead of the requested scope. Additionally, the query lacks a HAVING clause to ensure segment_id = 0 exists, which validates replay completeness.
| ): | ||
| # EAP stores replay_id in hex without dashes | ||
| replay_ids_no_dashes = [replay_id.replace("-", "") for replay_id in replay_ids] | ||
|
|
There was a problem hiding this comment.
Bug: EAP query returns incomplete data
The EAP query selects only a subset of fields compared to the non-EAP query path, which returns all fields from QUERY_ALIAS_COLUMN_MAP when fields=[]. Critical missing fields include trace_ids, error_ids, warning_ids, info_ids, user fields, environment, tags, urls, releases, replay_type, platform, dist, duration, activity, sdk, os, browser, device, ota_updates, click fields, and viewed_by_ids. This causes the EAP endpoint to return incomplete replay details compared to the standard query path.
As title says, this PR fixes a suspected "404 Not Found" bug that occurs when an EAP query is executed for a replay ID. The reason this is caused is likely because replay IDs are stored in hex without dashes in EAP, but the current query includes the dashes in the replay ID query, resulting in no data found.
Relates to: https://linear.app/getsentry/issue/REPLAY-824/create-query-function-for-replay-details