Skip to content

fix(eap): Update attribute key name provided in DeleteTraceItemsRequest RPCs #103867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2025
Merged

fix(eap): Update attribute key name provided in DeleteTraceItemsRequest RPCs #103867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/eventstream/eap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _create_group_id_filter(group_ids: list[int]) -> TraceItemFilter:
comparison_filter=ComparisonFilter(
key=AttributeKey(
type=AttributeKey.TYPE_INT,
name="sentry.group_id",
name="group_id",
),
op=ComparisonFilter.OP_IN,
value=AttributeValue(val_int_array=IntArray(values=group_ids)),
Expand Down
4 changes: 2 additions & 2 deletions tests/sentry/eventstream/test_eap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_deletion_with_error_dataset(self, mock_rpc):
assert len(request.filters) == 1
assert request.filters[0].item_type == TraceItemType.TRACE_ITEM_TYPE_OCCURRENCE
assert request.filters[0].filter.HasField("comparison_filter")
assert request.filters[0].filter.comparison_filter.key.name == "sentry.group_id"
assert request.filters[0].filter.comparison_filter.key.name == "group_id"
assert (
list(request.filters[0].filter.comparison_filter.value.val_int_array.values)
== self.group_ids
Expand All @@ -60,7 +60,7 @@ def test_multiple_group_ids(self, mock_rpc):
request = mock_rpc.call_args[0][0]
group_filter = request.filters[0].filter
assert group_filter.HasField("comparison_filter")
assert group_filter.comparison_filter.key.name == "sentry.group_id"
assert group_filter.comparison_filter.key.name == "group_id"
assert list(group_filter.comparison_filter.value.val_int_array.values) == many_group_ids

@patch("sentry.eventstream.eap.snuba_rpc.delete_trace_items_rpc")
Expand Down
Loading