Skip to content

Conversation

@mtopo27
Copy link
Contributor

@mtopo27 mtopo27 commented Nov 25, 2025

problem described in feedback here.

TL;DR - releases cards can have the same subset of title displayed, but the tooltip was getting cut off

PR vs. current

PR
tooltips show full content (can see the bundle ids are different)
image
https://github.com/user-attachments/assets/af731c7c-a4cd-4e79-aec2-c87cc09862d4

current prod (releases indistinguishable)
image

518449345-cc83dc76-05e0-46ad-aa23-edcc9cdc4b97.mov

For a hash release

intent is to not change current behavior

Tooltip on prod for a "hash release"
image

Tooltip in PR for a "hash release" (same thing)
image

Notes

Issues w/ previous implementation:

  • regex for hash version was incorrect given the version that's passed in. The version passed in is actually the full release string, that often will start with something like frontend@{hash}. Changed regex to be if there is a 40 or 64 character hash anywhere, which worked for the Sentry Javascript project
  • the overlayStyle wasn't actually doing anything, otherwise this never would have been issue. Switched to just use the maxWidth prop that's in the tooltip

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2025
Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better than before!

@mtopo27 mtopo27 merged commit dd321dd into master Nov 25, 2025
52 checks passed
@mtopo27 mtopo27 deleted the mtopo27/releases-tooltip-width branch November 25, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants