Skip to content

Conversation

@Zylphrex
Copy link
Member

This feature has been rolled out so we can delete the flag now.

This feature has been rolled out so we can delete the flag now.

Depends on #104016
@Zylphrex Zylphrex requested a review from a team as a code owner November 25, 2025 21:43
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 25, 2025
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test expects 400 but backend now allows request

The test test_high_accuracy_flex_time_without_feature_flag expects a 400 status code when using HIGHEST_ACCURACY_FLEX_TIME sampling mode, but the backend feature flag check was removed in organization_events.py. Without the feature flag gate, requests with this sampling mode will now succeed with a 200 status, causing this test to fail. The test should either be removed or updated to expect success.

tests/snuba/api/endpoints/test_organization_events_ourlogs.py#L899-L911

def test_high_accuracy_flex_time_without_feature_flag(self):
request = {
"field": ["timestamp", "message"],
"orderby": "-timestamp",
"project": self.project.id,
"dataset": self.dataset,
"sampling": "HIGHEST_ACCURACY_FLEX_TIME",
"per_page": 5,
}
response = self.do_request(request)
assert response.status_code == 400

Fix in Cursor Fix in Web


@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104017      +/-   ##
===========================================
+ Coverage   79.79%    80.62%   +0.83%     
===========================================
  Files        9317      9316       -1     
  Lines      397556    397495      -61     
  Branches    25389     25375      -14     
===========================================
+ Hits       317212    320484    +3272     
+ Misses      79892     76559    -3333     
  Partials      452       452              

@Zylphrex Zylphrex merged commit 72f35b6 into master Nov 26, 2025
97 of 99 checks passed
@Zylphrex Zylphrex deleted the txiao/chore/remove-ourlogs-high-fidelity-feature-flag-backend branch November 26, 2025 14:46
Zylphrex added a commit that referenced this pull request Nov 26, 2025
)

This flag has been rolled out so time to remove it.

Depends on #104017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants