-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(logs): Remove ourlogs-high-fidelity feature flag backend #104017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logs): Remove ourlogs-high-fidelity feature flag backend #104017
Conversation
This feature has been rolled out so we can delete the flag now. Depends on #104016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test expects 400 but backend now allows request
The test test_high_accuracy_flex_time_without_feature_flag expects a 400 status code when using HIGHEST_ACCURACY_FLEX_TIME sampling mode, but the backend feature flag check was removed in organization_events.py. Without the feature flag gate, requests with this sampling mode will now succeed with a 200 status, causing this test to fail. The test should either be removed or updated to expect success.
tests/snuba/api/endpoints/test_organization_events_ourlogs.py#L899-L911
sentry/tests/snuba/api/endpoints/test_organization_events_ourlogs.py
Lines 899 to 911 in 83c64c9
| def test_high_accuracy_flex_time_without_feature_flag(self): | |
| request = { | |
| "field": ["timestamp", "message"], | |
| "orderby": "-timestamp", | |
| "project": self.project.id, | |
| "dataset": self.dataset, | |
| "sampling": "HIGHEST_ACCURACY_FLEX_TIME", | |
| "per_page": 5, | |
| } | |
| response = self.do_request(request) | |
| assert response.status_code == 400 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104017 +/- ##
===========================================
+ Coverage 79.79% 80.62% +0.83%
===========================================
Files 9317 9316 -1
Lines 397556 397495 -61
Branches 25389 25375 -14
===========================================
+ Hits 317212 320484 +3272
+ Misses 79892 76559 -3333
Partials 452 452 |
) This flag has been rolled out so time to remove it. Depends on #104017
This feature has been rolled out so we can delete the flag now.