Skip to content

Conversation

@Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Nov 25, 2025

This flags has been rolled out so we can remove it now.

Depends on #104020 and #104016

This flag has been rolled out so we can remove it now.

Depends on #104020
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 25, 2025
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Frontend still checks removed feature flag

The backend flag visibility-explore-aggregate-editor is being removed, but the frontend code in static/app/views/explore/tables/index.tsx at line 110 still checks for this flag. After removal, the flag will no longer be in organization.features, causing the aggregate table editor button to become disabled instead of enabled, effectively disabling a feature that was rolled out.

src/sentry/features/temporary.py#L519-L521

manager.add("organizations:view-hierarchies-options-dev", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable equations feature on the new explore page
manager.add("organizations:visibility-explore-equations", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)

Fix in Cursor Fix in Web


Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unrelated feature flag removed without mention in PR

The PR title and description only mention removing visibility-explore-aggregate-editor, but this change also removes the unrelated organizations:ourlogs-high-fidelity flag which controls "UI for log high fidelity queries". This appears to be accidentally included in the commit since it's not mentioned in the PR scope and represents a different feature area (logs high fidelity vs explore aggregate editor).

src/sentry/features/temporary.py#L586-L587

# Enable service hooks outbox
manager.add("organizations:service-hooks-outbox", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)

Fix in Cursor Fix in Web


@Zylphrex Zylphrex changed the title chore(logs): Remove visibility-explore-aggregate-editor flag backend chore(explore): Remove used explore flag backend Nov 26, 2025
@Zylphrex Zylphrex merged commit 75a6cbc into master Nov 27, 2025
69 checks passed
@Zylphrex Zylphrex deleted the txiao/chore/remove-visibility-explore-aggregate-editor-flag-backend branch November 27, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants