Skip to content

fix: alert mail display invalid url (subpath in the SENTRY_URL_PREFIX was dropped) #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2013
Merged

fix: alert mail display invalid url (subpath in the SENTRY_URL_PREFIX was dropped) #1059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34bf538
fix: alert mail display invalid url (subpath in the SENTRY_URL_PREFIX…
shimizukawa Nov 14, 2013
ac50590
need ends with '/' for the urljoin's first argument.
shimizukawa Nov 14, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/utils/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
def absolute_uri(url=None):
if not url:
return settings.SENTRY_URL_PREFIX
return urljoin(settings.SENTRY_URL_PREFIX, url)
return urljoin(settings.SENTRY_URL_PREFIX.rstrip('/') + '/', url.lstrip('/'))


def safe_urlencode(params, doseq=0):
Expand Down