Skip to content

ref(vitals): Clean up web vitals constants #21389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 2 commits into from
Oct 16, 2020
Merged

ref(vitals): Clean up web vitals constants #21389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771c2bf
ref(vitals): Clean up web vitals constants
Zylphrex Oct 15, 2020
a55c6d5
Merge branch 'master' into ref/clean-up-web-vital-constants
Zylphrex Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/sentry/static/sentry/app/views/performance/realUserMonitoring/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,25 +80,29 @@ export const FILTER_OPTIONS: SelectValue<string>[] = [
{label: t('View All'), value: 'all'},
];

export const ZOOM_KEYS = Object.values(WebVital).reduce((zoomKeys: string[], vital) => {
const vitalSlug = WEB_VITAL_DETAILS[vital].slug;
zoomKeys.push(`${vitalSlug}Start`);
zoomKeys.push(`${vitalSlug}End`);
return zoomKeys;
}, []);

/**
* This defines the grouping for histograms. Histograms that are in the same group
* will be queried together on initial load for alignment. However, the zoom controls
* are defined for each measurement independently.
*/
const _VITAL_GROUPS = [[WebVital.FP, WebVital.FCP, WebVital.LCP], [WebVital.FID]];

const _COLORS = [
...theme.charts.getColorPalette(Object.values(WebVital).length - 1),
...theme.charts.getColorPalette(
_VITAL_GROUPS.reduce((count, group) => count + group.length, 0) - 1
),
].reverse();
export const VITAL_GROUPS = [
[WebVital.FP, WebVital.FCP, WebVital.LCP],
[WebVital.FID],
].map(group => ({

export const VITAL_GROUPS = _VITAL_GROUPS.map(group => ({
group,
colors: _COLORS.splice(0, group.length),
}));

export const ZOOM_KEYS = _VITAL_GROUPS.reduce((keys: string[], group) => {
group.forEach(vital => {
const vitalSlug = WEB_VITAL_DETAILS[vital].slug;
keys.push(`${vitalSlug}Start`);
keys.push(`${vitalSlug}End`);
});
return keys;
}, []);