ref: Delete activity as part of group deletion, not project deletion #21611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jan-auer
approved these changes
Oct 28, 2020
Member
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
LGTM, leaving final approval to the grown-ups.
Member
Author
|
matt argued that we might show activity for deleted groups in global activity stream. Trying out with https://sentry.io/organizations/markustest/activity/:
need to wait for group deletion |
Member
Author
|
@mattrobenolt when visiting the above link you'll see that groupactivity is hidden after the group has been deleted. So deleting this model sooner won't have any effect. |
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We couldn't find a reason to keep them around for the lifetime of the project.