feat(ui): Add new Collapsible component #22647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
Dec 14, 2020
| const {collapseButton} = this.props; | ||
|
|
||
| if (typeof collapseButton === 'function') { | ||
| return collapseButton({handleCollapse: this.onCollapseToggle}); |
Member
There was a problem hiding this comment.
We should swap the prefixes here, the callback should be onCollapse and the method should be this.handleCollapseToggle.
Comment on lines
17
to
19
| expect(wrapper.find('Button[data-test-id="expand"]').text()).toBe( | ||
| 'Show 2 collapsed items' | ||
| ); |
Member
There was a problem hiding this comment.
imo we shouldn't use data-test-id for Buttons, we should instead use aria-label as that'll build good habits to ensure that our buttons are accessible.
Member
Author
There was a problem hiding this comment.
sure thing, let me switch to that
markstory
approved these changes
Dec 15, 2020
|
|
||
| return ( | ||
| <React.Fragment> | ||
| {itemsToRender.map(item => item)} |
Member
There was a problem hiding this comment.
Do you need this map? There are no changes/extraction being done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this pattern already in multiple places and each has its own implementation.
In the follow-up PR, I will replace all of them with this reusable one.