-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(notification platform): Handle multiple providers #25018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
347aea8 to
ba87e65
Compare
src/sentry/notifications/helpers.py
Outdated
| NotificationSettingTypes.ISSUE_ALERTS, | ||
| ) | ||
| output = [] | ||
| for provider, value in mapping.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ceorourke seems like you could use filter here to build output instead of doing it itereatively
|
You should delete the unused functions |
3e49719 to
eabe9c7
Compare
mgaeta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
27e6a00 to
e3cc8d5
Compare
* feat(notification platform): Handle multiple providers
This is one of several PRs to update the notification settings manager functions to return a mapping of providers to a list of users instead of a list of users (what we had previously) to account for the fact that email is no longer the only means of contacting a user.
Ex:
{"email": [<User 1>, <User 2>], "slack", ["User 1, User 3]}