Skip to content

fix(ts): Improve type for errors on AsyncComponent #25290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leedongwei merged 1 commit into from
Apr 15, 2021
Merged

fix(ts): Improve type for errors on AsyncComponent #25290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/asyncComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type AsyncComponentState = {
loading: boolean;
reloading: boolean;
error: boolean;
errors: object;
errors: Record<string, JQueryXHR>;
remainingRequests?: number;
[key: string]: any;
};
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/views/dashboardsV2/orgDashboards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class OrgDashboards extends AsyncComponent<Props, State> {
loading: true,
reloading: false,
error: false,
errors: [],
errors: {},

dashboards: [],
selectedDashboard: null,
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/views/eventsV2/eventDetails/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class EventDetailsContent extends AsyncComponent<Props, State> {
loading: true,
reloading: false,
error: false,
errors: [],
errors: {},
event: undefined,

// local state
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/views/eventsV2/landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class DiscoverLanding extends AsyncComponent<Props, State> {
loading: true,
reloading: false,
error: false,
errors: [],
errors: {},

// local component state
isBannerHidden: isBannerHidden(),
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/views/performance/transactionDetails/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class EventDetailsContent extends AsyncComponent<Props, State> {
loading: true,
reloading: false,
error: false,
errors: [],
errors: {},
event: undefined,

// local state
Expand Down