Skip to content

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Jan 13, 2016

This adjusts team scoping to add an additional 'can access' concept in addition to 'is member'. When a team has open membership, or a user is a superuser, they will have access to teams but not (by default) be a member. This most importantly allows users to view issue details without joining a team, and also fixes some odd behavior wherein superusers appeared like members when they weren't.

Fixes GH-2241

@dcramer dcramer force-pushed the access-v-membership branch from 6789a42 to 49d002c Compare January 13, 2016 00:05
This adjusts team scoping to add an additional 'can access' concept in addition to 'is member'. When a team has open membership, or a user is a superuser, they will have access to teams but not (by default) be a member. This most importantly allows users to view issue details without joining a team, and also fixes some odd behavior wherein superusers appeared like members when they weren't.

Fixes GH-2241
@dcramer dcramer force-pushed the access-v-membership branch from 49d002c to 51fec6c Compare January 13, 2016 00:07
@codecov-io
Copy link

Current coverage is 82.92%

Merging #2540 into master will increase coverage by +0.01% as of 51fec6c

@@            master   #2540   diff @@
======================================
  Files          860     860       
  Stmts        32053   32092    +39
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          26578   26613    +35
  Partial          0       0       
- Missed        5475    5479     +4

Review entire Coverage Diff as of 51fec6c


Uncovered Suggestions

  1. +0.07% via ...try/utils/apidocs.py#414...436
  2. +0.07% via ...try/utils/apidocs.py#117...139
  3. +0.07% via ...gs/sentry_helpers.py#191...211
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

dcramer added a commit that referenced this pull request Jan 13, 2016
Vary access and membership for teams
@dcramer dcramer merged commit 22ee327 into master Jan 13, 2016
@dcramer dcramer deleted the access-v-membership branch January 13, 2016 00:19
mattrobenolt pushed a commit that referenced this pull request Jan 13, 2016
Vary access and membership for teams
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants