Skip to content

perf(org-stats): Switch to use Lightweight Organization #25474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leedongwei merged 1 commit into from
Apr 21, 2021
Merged

perf(org-stats): Switch to use Lightweight Organization #25474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions static/app/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,6 +1690,16 @@ function routes() {
component={errorHandler(LazyLoad)}
/>

<Route
path="/organizations/:orgId/stats/"
componentPromise={() =>
import(
/* webpackChunkName: "OrganizationStats" */ 'app/views/organizationStats'
)
}
component={errorHandler(LazyLoad)}
/>

<Route
path="/organizations/:orgId/projects/:projectId/events/:eventId/"
component={errorHandler(ProjectEventRedirect)}
Expand Down Expand Up @@ -2024,15 +2034,6 @@ function routes() {
<Route path="/:orgId/" component={errorHandler(OrganizationDetails)}>
<Route component={errorHandler(OrganizationRoot)}>
{hook('routes:organization-root')}
<Route
path="/organizations/:orgId/stats/"
componentPromise={() =>
import(
/* webpackChunkName: "OrganizationStats" */ 'app/views/organizationStats'
Copy link
Member

@markstory markstory Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your view rely on organization.projects or is it already using withProjects?

Copy link
Member Author

@leedongwei leedongwei Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep we're using withProjects.

Copy link
Member Author

@leedongwei leedongwei Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usageStatsProjects component looks for loadingProjectsbeing passed from withProjects too, so the loading state is handled.

)
}
component={errorHandler(LazyLoad)}
/>

<Route
path="/organizations/:orgId/projects/:projectId/getting-started/"
Expand Down