Skip to content

Stylize disabled client keys more obviously #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattrobenolt merged 1 commit into from
Jan 29, 2016
Merged

Stylize disabled client keys more obviously #2621

mattrobenolt merged 1 commit into from
Jan 29, 2016

Conversation

@mattrobenolt
Copy link
Contributor

@mattrobenolt mattrobenolt commented Jan 29, 2016

  • Sort disabled keys below active keys
  • Dim disabled keys
  • Add a "Disabled" label
  • Remove blue "Enable" button

Fixes GH-2572

image

@mattrobenolt
Stylize disabled client keys more obviously
1abb4a2 
* Sort disabled keys below active keys
* Dim disabled keys
* Add a "Disabled" label
* Remove blue "Enable" button

Fixes GH-2572
@codecov-io
Copy link

codecov-io commented Jan 29, 2016

Current coverage is 83.23%

Merging #2621 into master will not affect coverage as of 5bf24f0

@@            master   #2621   diff @@
======================================
  Files          864     864       
  Stmts        32654   32654       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit          27179   27179       
  Partial          0       0       
  Missed        5475    5475

Review entire Coverage Diff as of 5bf24f0

Uncovered Suggestions

  1. +0.07% via ...try/utils/apidocs.py#414...436
  2. +0.07% via ...try/utils/apidocs.py#117...139
  3. +0.06% via ...gs/sentry_helpers.py#191...211
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@ckj
Copy link
Member

ckj commented Jan 29, 2016

Cool, like the fade effect. 👍

mattrobenolt added a commit that referenced this pull request Jan 29, 2016
@mattrobenolt
Merge pull request #2621 from getsentry/keys
6eec7f9 
Stylize disabled client keys more obviously
@mattrobenolt mattrobenolt merged commit 6eec7f9 into master Jan 29, 2016
@mattrobenolt mattrobenolt deleted the keys branch January 29, 2016 23:45
mattrobenolt added a commit that referenced this pull request Feb 1, 2016
@mattrobenolt
Merge pull request #2621 from getsentry/keys
cdccd88 
Stylize disabled client keys more obviously
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI for disabled client keys (DSN) is not obvious

4 participants

@mattrobenolt @codecov-io @ckj