Skip to content

Manually set our $PATH before executing uwsgi bin #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattrobenolt merged 1 commit into from
Feb 5, 2016
Merged

Manually set our $PATH before executing uwsgi bin #2650

mattrobenolt merged 1 commit into from
Feb 5, 2016

Conversation

@mattrobenolt
Copy link
Contributor

@mattrobenolt mattrobenolt commented Feb 5, 2016

This fixes cases when spawning sentry bin without activating our
virtualenv. We derive the $PATH based on where sentry was run from,
and uwsgi should be sitting next to it.

Fixes GH-2649

@mattrobenolt
Manually set our $PATH before executing uwsgi bin
dc84b8d 
This fixes cases when spawning `sentry` bin without activating our
virtualenv. We derive the $PATH based on where `sentry` was run from,
and `uwsgi` should be sitting next to it.

Fixes GH-2649
@mattrobenolt mattrobenolt mentioned this pull request Feb 5, 2016
Closed
@codecov-io
Copy link

codecov-io commented Feb 5, 2016

Current coverage is 83.20%

Merging #2650 into master will decrease coverage by -0.02% as of dc84b8d

@@            master   #2650   diff @@
======================================
  Files          864     864       
  Stmts        32697   32701     +4
  Branches         0       0       
  Methods          0       0       
======================================
- Hit          27213   27210     -3
  Partial          0       0       
- Missed        5484    5491     +7

Review entire Coverage Diff as of dc84b8d

Uncovered Suggestions

  1. +0.07% via ...try/utils/apidocs.py#414...436
  2. +0.07% via ...try/utils/apidocs.py#117...139
  3. +0.07% via ...gs/sentry_helpers.py#191...211
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

mattrobenolt added a commit that referenced this pull request Feb 5, 2016
@mattrobenolt
Merge pull request #2650 from getsentry/fix-path
e212a0e 
Manually set our $PATH before executing uwsgi bin
@mattrobenolt mattrobenolt merged commit e212a0e into master Feb 5, 2016
@mattrobenolt mattrobenolt deleted the fix-path branch February 5, 2016 21:32
@mattrobenolt mattrobenolt mentioned this pull request Feb 6, 2016
Closed
mattrobenolt added a commit that referenced this pull request Feb 6, 2016
@mattrobenolt
Merge pull request #2650 from getsentry/fix-path
9c77dcb 
Manually set our $PATH before executing uwsgi bin
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattrobenolt @codecov-io