fix(arithmetic): removing equation from autocomplete/yaxis #26600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Equations were showing up in autocomplete and the y-axis even though they're not currently supported in either, but because they're in the list of fields were being picked up by these two things
dashed
approved these changes
Jun 14, 2021
dashed
reviewed
Jun 14, 2021
| .filter((field: Field) => isLegalYAxisType(aggregateOutputType(field.field))) | ||
| .filter( | ||
| (field: Field) => | ||
| isLegalYAxisType(aggregateOutputType(field.field)) && !isEquation(field.field) |
Member
There was a problem hiding this comment.
@wmak would equations ever show up as y-axis options in Dashboards?
Member
Author
There was a problem hiding this comment.
They will, this is temporary until I add support on the event-stats endpoint for equations, and I'll format it correctly when I add it back, right now this is appearing like this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they're not currently supported in either, but because they're in the
list of fields were being picked up by these two things