feat(release-comparison): Add issue filter tabs to release details #26826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add issue filter tabs to release details for Release Comparison feature. FIXES WOR-968
matejminar
reviewed
Jun 23, 2021
matejminar
reviewed
Jun 25, 2021
Member
matejminar
left a comment
matejminar
left a comment
There was a problem hiding this comment.
Kapture.2021-06-25.at.11.09.19.mp4
There seems to be a race condition or something when you switch tabs quickly.
matejminar
reviewed
Jul 2, 2021
Comment on lines
64
to
65
| and not features.has( | ||
| "organizations:release-comparison", organization, actor=request.user |
Member
There was a problem hiding this comment.
Do we still need this? From release details we always ask for single project.
static/app/utils/theme.tsx
Outdated
Comment on lines
242
to
247
| issueCountActiveText: colors.gray100, | ||
|
|
||
| /** | ||
| * Issue count when tab not active | ||
| */ | ||
| issueCountNotActiveText: colors.gray400, |
Member
There was a problem hiding this comment.
Should we name these in a more generic way? Perhaps buttonCount?
| onClick={() => this.handleIssuesTypeSelection(value)} | ||
| > | ||
| {label} | ||
| <QueryCount count={issueCount} max={99} hideParens hideIfEmpty /> |
Member
There was a problem hiding this comment.
We still want number 0 to show up.
Suggested change
| <QueryCount count={issueCount} max={99} hideParens hideIfEmpty /> | |
| <QueryCount count={issueCount} max={99} hideParens hideIfEmpty={false} /> |
Comment on lines
240
to
244
| all: issueResponse[`${IssuesQuery.ALL}:${version}`], | ||
| new: issueResponse[`${IssuesQuery.NEW}:${version}`], | ||
| resolved: resolvedResponse.length, | ||
| unhandled: | ||
| issueResponse[`${IssuesQuery.UNHANDLED} ${IssuesQuery.ALL}:${version}`], |
Member
There was a problem hiding this comment.
Let's fallback to 0 because this endpoint returns null in case of no issues and we want to see 0 in the buttonbar.
Suggested change
| all: issueResponse[`${IssuesQuery.ALL}:${version}`], | |
| new: issueResponse[`${IssuesQuery.NEW}:${version}`], | |
| resolved: resolvedResponse.length, | |
| unhandled: | |
| issueResponse[`${IssuesQuery.UNHANDLED} ${IssuesQuery.ALL}:${version}`], | |
| all: issueResponse[`${IssuesQuery.ALL}:${version}`] || 0, | |
| new: issueResponse[`${IssuesQuery.NEW}:${version}`] || 0, | |
| resolved: resolvedResponse.length, | |
| unhandled: | |
| issueResponse[`${IssuesQuery.UNHANDLED} ${IssuesQuery.ALL}:${version}`] || 0, |
Comment on lines
465
to
467
| span:last-child { | ||
| color: ${p => p.theme.issueCountNotActiveText}; | ||
| } |
Member
There was a problem hiding this comment.
We do not need to do it now, but the preferred way in the future would be to define StyledQueryCount instead of nested selectors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add issue filter tabs with issue counts to the release details page. Browser URL query will also update based on the selected tab and provide a direct link to that tab.
FIXES WOR-968
Before
After