feat(ui): Rename resolved in options, add analytics #27192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Jul 7, 2021
| <MenuItemActionLink | ||
| {...actionLinkProps} | ||
| title={t('Another version')} | ||
| title={t('Another existing release')} |
Member
There was a problem hiding this comment.
is existing needed? Seems a bit redundant. What is a non-existent release?
Member
Author
There was a problem hiding this comment.
A couple of customers and even some employees thought that they can enter there any version name (even future one) in which the issue will be resolved. (Especially in semver world)
| {...deps} | ||
| onSelected={(statusDetails: ResolutionStatusDetails) => | ||
| this.onCustomResolution(statusDetails) | ||
| this.handleAnotherExistingReleaseResolution(statusDetails) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another version...toAnother existing release.