ref(perf): Add projects tag to sdk update endpoint #27408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having looked at some performance profiles, sdk-updates seems to be heavily affected by the number of passed projects. This will add a tag to the transaction so that it will show up in suspect tags and can be analyzed using the tag page.
wmak
approved these changes
Jul 14, 2021
| project_ids = self.get_requested_project_ids(request) | ||
| projects = self.get_projects(request, organization, project_ids) | ||
|
|
||
| len_projects = len(project_ids) |
Member
There was a problem hiding this comment.
can we add the ungrouped tag here too?
Member
Author
There was a problem hiding this comment.
I actually was intentionally limiting the number of tags, I don't usually use ungrouped. Do you think it'd be helpful?
Member
There was a problem hiding this comment.
Yeah ungrouped has been helpful in debugging before, one more tag shouldn't be a huge deal and imo better to have it and not use it than want it and not have it 🤷
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Having looked at some performance profiles, sdk-updates seems to be heavily affected by the number of passed projects. This will add a tag to the transaction so that it will show up in suspect tags and can be analyzed using the tag page.