fix(features): Skip the entity handler after batch checking #28611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds the ability to skip the entity handler entirely when calling features.has - This is becaue when there are a lot of non entity features to check we're actually spending time checking that the feature is indeed not an entity feature
Zylphrex
approved these changes
Sep 17, 2021
| # Remaining features should not be checked via the entity handler | ||
| for feature_name in org_features: | ||
| if features.has(feature_name, obj, actor=user): | ||
| if features.has(feature_name, obj, skip_entity=True, actor=user): |
Member
There was a problem hiding this comment.
nit: keep the order as the definition so features.has(features_name, obj, actor=user, skip_entity=True)
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
* fix(features): Skip the entity handler after batch checking - This adds the ability to skip the entity handler entirely when calling features.has - This is becaue when there are a lot of non entity features to check we're actually spending time checking that the feature is indeed not an entity feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features.has
we're actually spending time checking that the feature is indeed not
an entity feature
Preview
Before
After