py38: cannot set_result more than once #28700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarli
commented
Sep 20, 2021
| with self._condition: | ||
| # This method always overwrites the result, so we always overwrite | ||
| # the timing, even if another timing was already recorded. | ||
| result = super().set_result(*args, **kwargs) |
Member
Author
There was a problem hiding this comment.
Reordered things to not overwrite the timings in case set_result raises.
wedamija
reviewed
Sep 20, 2021
wedamija
approved these changes
Sep 20, 2021
wedamija
approved these changes
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3.8/library/concurrent.futures.html?highlight=concurrent%20futures#concurrent.futures.Future.set_result
In Python 3.8, set_result is gonna raise concurrent.futures.InvalidStateError if we call it more than once. I think this is desirable and we should just adjust the test cases to not do that.