types(python): Group API Helpers #29424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanh
reviewed
Oct 20, 2021
Member
evanh
left a comment
evanh
left a comment
There was a problem hiding this comment.
Thanks for this! One small fix, also the backend typing CI is failing.
evanh
approved these changes
Oct 20, 2021
Member
evanh
left a comment
evanh
left a comment
There was a problem hiding this comment.
Looks good to me, but please fix the CI check before merging.
mgaeta
force-pushed
the
ref/update-groups-3
branch
from
2a89e23 to
f873b8a
Compare
mgaeta
force-pushed
the
ref/update-groups-3
branch
from
f873b8a to
de0b573
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding types to the group API helper files. This builds on #29302 which splits up a large file.