fix(deletions) Only fire pending_delete signal if deletion will happen #29443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a deletion is aborted via an undelete then we don't need to fire the pending_delete signal. Firing this signal when the delete is not going to proceed has led to organizations not being un-deleteable as the cleanup jobs for subscriptions in getsentry re-delete the organization. I've also added an easier to operate cancel feature to ScheduledDeletion that allows us to skip some work when a record is undeleted.
evanh
approved these changes
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a deletion is aborted via an undelete then we don't need to fire the pending_delete signal. Firing this signal when the delete is not going to proceed has led to organizations not being un-deleteable as the cleanup jobs for subscriptions in getsentry re-delete the organization.
I've also added an easier to operate cancel feature to ScheduledDeletion that allows us to skip some work when a record is undeleted.