fix(incidents): Set a threshold in email resolve notifications #29474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix that sets a threshold for resolve notifications when no `alert.resolve_threshold` is set. Prior to this fix, the email notification would just show a `None` value for the threshold value
matejminar
approved these changes
Oct 21, 2021
Contributor
Author
|
@wedamija Let me know if you don't agree with this, and we'll revert if so |
wedamija
reviewed
Oct 21, 2021
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for fixing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that sets a threshold for resolve notifications
when no
alert.resolve_thresholdis set. Prior tothis fix, the email notification would just show
a
Nonevalue for the threshold valueLike the following
